Issue 11148 - Make dmake 64-bit clean
Summary: Make dmake 64-bit clean
Status: CLOSED FIXED
Alias: None
Product: Build Tools
Classification: Code
Component: code (show other issues)
Version: OOo 1.0.2
Hardware: PC Linux, all
: P3 Trivial (vote)
Target Milestone: OOo 1.1 Beta2
Assignee: quetschke
QA Contact: issues@tools
URL:
Keywords:
Depends on:
Blocks: 8577
  Show dependency tree
 
Reported: 2003-02-03 10:10 UTC by gbeauche
Modified: 2003-03-08 08:48 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
Let explicitly-sized integral types configure detected (5.05 KB, patch)
2003-02-03 10:10 UTC, gbeauche 		no flags Details | Diff
Make dmake work with MSVC again (625 bytes, patch)
2003-02-14 19:06 UTC, quetschke 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description gbeauche 2003-02-03 10:10:13 UTC 
Hi, this is cosmetic change for dmake so that it is better 64-bit clean though
it used to work in the past as is.
Comment 1 gbeauche 2003-02-03 10:10:54 UTC 
Created attachment 4541 [details]
Let explicitly-sized integral types configure detected
Comment 2 foskey 2003-02-03 10:41:30 UTC 
Patch accepted and approved for all except OOO_STABLE_1.  This is not
a critical fix leave until proven a little while.
Comment 3 foskey 2003-02-13 12:19:48 UTC 
Applied to OO 644.
Comment 4 quetschke 2003-02-14 19:05:57 UTC 
Hi Ken,

the itypes change broke MSVC, I committed the following patch
as obvious fix.

Volker
Comment 5 quetschke 2003-02-14 19:06:57 UTC 
Created attachment 4741 [details]
Make dmake work with MSVC again
Comment 6 foskey 2003-02-14 20:02:00 UTC 
This is a problem.   Can you remove the config.h file entirely and
verify that it compiles correctly.  If it does can you commit the
following:

rm & cvs remove:

./msdos/borland/bcc30/config.h
./msdos/borland/bcc40/config.h
./msdos/borland/bcc45/config.h
./msdos/borland/bcc50/config.h
./msdos/borland/tcc20/config.h
./msdos/microsft/config.h
./msdos/zortech/config.h
./os2/ibm/config.h
./win95/borland/bcc50/config.h
./win95/microsft/config.h
./winnt/borland/bcc50/config.h
./winnt/microsft/config.h
Comment 7 foskey 2003-02-17 04:36:20 UTC 
PLease test and implement windows changes as outlined.
Comment 8 quetschke 2003-02-17 08:10:53 UTC 
No, won't work!

The MSVC build doesn't use configure, and therefor doesn't
generate a valid dmake/config.h.

The only needed config.h for the MSVC build is:
 ./win95/microsft/config.h
It contains the values that otherwise configure would find.

I don't see a solution as long as we use the
 dmake\make.bat win95-vpp40
command to generate dmake.exe for W32-4nt and I don't like the
idea of using the autotools with MSVC.

One possibility is to merge dmake from the vq_mingw branch, that
version would build a native w32 dmake.exe with configure. I will
do this in the next cws_... branch.
Comment 9 quetschke 2003-02-26 22:57:57 UTC 
Continuing the Winnt work in issue 11861.

Closing issue ...
Comment 10 quetschke 2003-03-08 08:48:37 UTC 
Mark CLOSED