Issue 109170 - Simplify mechanism to track cells containing external references.
Summary: Simplify mechanism to track cells containing external references.
Status: CLOSED FIXED
Alias: None
Product: Calc
Classification: Application
Component: code (show other issues)
Version: DEV300m71
Hardware: Unknown All
: P3 Trivial (vote)
Target Milestone: ---
Assignee: yfjiang
QA Contact: issues@sc
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-02-11 19:20 UTC by kyoshida
Modified: 2017-05-20 10:34 UTC (History)
1 user (show)

See Also:
Issue Type: TASK
Latest Confirmation in: ---
Developer Difficulty: ---


Attachments

Note You need to log in before you can comment on or make changes to this issue.
Description kyoshida 2010-02-11 19:20:43 UTC
The current mechanism to keep track of all formula cells containing external
references is a bit awkward & IMO is done the wrong way.  Let's rework it to do
it right.  We should be able to simplify it and reduce the amount of code for it
without sacrificing the functionality.  Less code, better maintenance.
Comment 1 kyoshida 2010-02-11 19:21:28 UTC
I think I can do this within the 3.3 time frame.  But we'll see how it goes.
Comment 2 kyoshida 2010-03-06 00:48:21 UTC
The first round is done:
http://hg.services.openoffice.org/hg/cws/koheiextref01/rev/68751b02f6ae
Comment 3 kyoshida 2010-03-08 14:52:21 UTC
Now the external ref manager keeps track of formula cells including external
references much more reliably.  For instance, when a cell no longer references
external documents, it take that cell off the list, which it previously did not do.
Comment 4 kyoshida 2010-03-08 16:52:51 UTC
The second round is done.  Iterate through the formula cells stored with the
external ref manager, instead of scanning all the formula cells in the document
looking for external references.

http://hg.services.openoffice.org/hg/cws/koheiextref01/rev/8760da03bdc5

This change concludes this task.
Comment 5 kyoshida 2010-04-29 03:24:48 UTC
Re-assigning to oc for verification.
Comment 6 kyoshida 2010-05-26 16:31:21 UTC
Re-assigning to Yi Fan for verification.
Comment 7 yfjiang 2010-05-31 03:34:30 UTC
Verified on SLED 11 sp1 and Windows xp sp3.