Issue 105219 - oox to-be-m60: include string.h in tokenmap.cxx
Summary: oox to-be-m60: include string.h in tokenmap.cxx
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Code
Component: code (show other issues)
Version: DEV300m59
Hardware: All All
: P3 Trivial (vote)
Target Milestone: OOo 3.2
Assignee: daniel.rentz
QA Contact: issues@xml
URL:
Keywords: oooqa
: 105449 (view as issue list)
Depends on:
Blocks:
 
Reported: 2009-09-20 15:20 UTC by tono
Modified: 2009-10-20 09:18 UTC (History)
2 users (show)

See Also:
Issue Type: PATCH
Latest Confirmation in: ---
Developer Difficulty: ---

Attachments
The modification (385 bytes, patch)
2009-09-20 15:22 UTC, tono 		no flags Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this issue.
Description tono 2009-09-20 15:20:55 UTC 
In to-be-m60, inclusion of string.h is removed from 
oox/source/token/tokenmap.cxx with the integration of cws dr69. Maybe the 
include file is implicitly included on many platforms but not on mingw gcc-
4.4.0 with gcc STL library. mingw gcc-3.4.4 has no problem.

It will break the build as gperf generates string comparison code in tokens.inc.

I think it is safe to include string.h for all platforms explicitly.
Comment 1 tono 2009-09-20 15:22:30 UTC 
Created attachment 64869 [details]
The modification
Comment 2 daniel.rentz 2009-09-20 15:27:34 UTC 
started
Comment 3 daniel.rentz 2009-09-25 16:42:47 UTC 
fixed
Comment 4 lohmaier 2009-09-27 10:24:35 UTC 
This issue could have been avoided if you wouldn't have ignored tinderbox status
on the dr69 cws.

Also sad to see that it wasn't masterfixed but put into a regular cws :-(
Comment 5 daniel.rentz 2009-09-28 16:53:55 UTC 
verified in cws build
Comment 6 daniel.rentz 2009-09-29 14:16:16 UTC 
*** Issue 105449 has been marked as a duplicate of this issue. ***
Comment 7 daniel.rentz 2009-10-20 09:18:33 UTC 
closed