Apache OpenOffice (AOO) Bugzilla – Issue 102637
After updating to 3.1: printed slides are no longer framed
Last modified: 2009-07-30 11:30:46 UTC
I updated from 3.0.1 to 3.1, loaded a presentation I last worked on with 3.0.1., and printed handouts with 2 slides on a page. I noticed that the slides are unfortunately not framed any longer in the output. This effect has been reproduced by at least one other user, see http://user.services.openoffice.org/en/forum/viewtopic.php?f=10&t=19555 This was a showstopper, because I had to produce handouts for a commercial seminar, and the missing frames makes them look unprofessional. This is the third time for me that a new stable release version of OO.org introduced a problem in Impress that impairs a previously flawlessly working feature (stable releases should really not do that).
Reproducible. Reassigned. By the way: did you test the developer builds and the release candidates before the final version? This would have been a way of finding these kind of problems earlier..
reassigned
No, testing the developer builds and the release candidates is unfortunately only very rarely an option for me, for various reasons.
AW: Taking a look. In OOO310 m12, inside the primitive creation callback, no geometry at all is created for the SdrPage objects. Getting a DEV300 m29 SD, adding some debug and taking a look who/where that frame was painted at all in the 3.0 version...
AW: Frame is painted at ViewContactOfPageObj::PaintObject when if(!(rDisplayInfo.OutputToPrinter() && !pPage)) is true. Thus, when printing, a frame is painted when pPage is set. Checking OOO310 m12 code...
AW: Indeed, the ViewObjectContactOfPageObj::createPrimitive2DSequence which is responsible for primitive creation only has a if(!GetObjectContact().isOutputToPrinter()) condition for adding the frame. Adding '|| pPage' condition and taking a look...
AW: Compared all cases between DEV300 m29 and OOO310 m12: Page pane, notes view, handout view, Slide sorter, print (with all 4 variations), export to PDF (with handouts). All looks the same as in 3.0 with that change. To make sure i re-compared with unchanged OOO310 m12: Error is in printing handouts and in printing notes. No error in PDF export with slides (noprinter used). Adding patch to this task..
Created attachment 63356 [details] Patch with fix
AW: Discussed with QA, adding to CWS aw074, changing target to 3.1.1. Done.
AW: Ckecked with wntmsci12.pro build, works as expected.
AW->WG: Please review as described.
Verified in CWS.
Tested in m17. Closed.