Issue 128455

Summary: update JUnit4 from 4.12 to latest 4.13.2
Product: QA Reporter: Carl Marcum <cmarcum>
Component: frameworkAssignee: AOO issues mailing list <issues>
Status: RESOLVED FIXED QA Contact: Carl Marcum <cmarcum>
Severity: Normal    
Priority: P5 (lowest)    
Version: 4.2.0-dev   
Target Milestone: ---   
Hardware: All   
OS: All   
Issue Type: ENHANCEMENT Latest Confirmation in: 4.1.10
Developer Difficulty: Medium

Description Carl Marcum 2021-05-30 20:16:37 UTC 
Issue to track work on updating JUnit from 4.12 to latest JUnit4 4.13.2.
Previous updating from 4.10 to 4.12 was under issue 128452 [1].

This update will require changes to NamedRequest.java [2] due to a change in JUnit 4.13 ParentRunner.java [3] where a second constructor was added which now throws an error when instantiating the inner class Suite with a null arg.

[javac] <path-to>/openoffice/test/testcommon/source/org/openoffice/test/common/NamedRequest.java:161: error: reference to ParentRunner is ambiguous, both constructor ParentRunner(Class<?>) in ParentRunner and constructor ParentRunner(TestClass) in ParentRunner match
    [javac] 			super(null);
    [javac] 			^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error
    [javac] 1 warning

BUILD FAILED
/home/carl/dev-git/openoffice/test/build.xml:80: Compile failed; see the compiler error output for details.

[1] https://bz.apache.org/ooo/show_bug.cgi?id=128452

[2] https://github.com/apache/openoffice/blob/trunk/test/testcommon/source/org/openoffice/test/common/NamedRequest.java

[3] https://github.com/junit-team/junit4/blob/main/src/main/java/org/junit/runners/ParentRunner.java