|
Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
| Summary: | Failure due to moving absent file | ||
|---|---|---|---|
| Product: | Build Tools | Reporter: | vorobyov.mikhail |
| Component: | solenv | Assignee: | AOO issues mailing list <issues> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | Normal | ||
| Priority: | P5 (lowest) | CC: | mseidel |
| Version: | 4.2.0-dev | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | PATCH | Latest Confirmation in: | --- |
| Developer Difficulty: | --- | ||
A "blocker" would make the program unusable or break the build process. Can you prove that this is the case? Anyhow, since the code is on GitHub, could you open a Pull Request there? (In reply to Matthias Seidel from comment #1) > A "blocker" would make the program unusable or break the build process. > Can you prove that this is the case? > > Anyhow, since the code is on GitHub, could you open a Pull Request there? I've opened a Pull Request https://github.com/apache/openoffice/pull/110. Thanks! It seems that this part was removed in trunk long ago: https://github.com/apache/openoffice/commit/25a457539c4c9ee45d9cc1446a569f5b1532c064#diff-90c5bad7c7b6152ce7d0426fcd732255bf60d14520a136753531608f7c986757 Somehow it was never backported to AOO42X. Merged with: https://github.com/apache/openoffice/pull/110 Thanks! |
Remove code that uses a non-existent file This code block tries to move $outfile while the previous code doesn't create $outfile; only $outfile_sh and possibly $outfile_bat are created. --- a/main/set_soenv.in +++ b/main/set_soenv.in @@ -2167,11 +2167,6 @@ if( defined($outfile_bat)) # XI. Moving the output file to the build home directory. #-------------------------------------------------------- # -$tmp = $SRC_ROOT.$ds.$outfile; -if (rename( $outfile, $tmp ) ne 1) -{ `mv -f $outfile $tmp`; -} - $tmp = $SRC_ROOT.$ds.$outfile_sh; if (rename( $outfile_sh, $tmp ) ne 1) { `mv -f $outfile_sh $tmp`;