Apache OpenOffice (AOO) Bugzilla – Full Text Issue Listing |
Summary: | remove sh-script code: obsolete which() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | General | Reporter: | flibby05 | ||||||
Component: | code | Assignee: | AOO issues mailing list <issues> | ||||||
Status: | CONFIRMED --- | QA Contact: | |||||||
Severity: | Trivial | ||||||||
Priority: | P3 | CC: | issues | ||||||
Version: | 680m109 | ||||||||
Target Milestone: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Unix, all | ||||||||
Issue Type: | ENHANCEMENT | Latest Confirmation in: | --- | ||||||
Developer Difficulty: | --- | ||||||||
Attachments: |
|
Description
flibby05
2005-06-20 17:40:24 UTC
Created attachment 27345 [details]
patch1
Created attachment 27346 [details]
patch2
attached 2 patches cosmetic reassigned to obr... mci -> obr: Hi obr, as dicussed: this is one of th issues about browser-detection on UNIX/Linux... Hmm, /usr/bin/which is a csh script on Solaris, which unfortunatly sources ~/.cshrc. As soon as people do any terminal output in the cshrc, the result of a call to /usr/bin/which is unpredictable. Therefore I would prefer leaving those few lines of shell code in. This is too risky for a .0.x release - I also believe we should leave the code in, adding a comment why this solution has been prefered over /usr/bin/which. I think we should come to a decision how we would like to move forward with the usage of which and the patch. Changing target to "not determined" ... I still don't think using /usr/bin/which on Solaris is a good idea, so my take on this would be to move the code to an extra scriptlet, that only gets packaged and sourced by the other scripts on Solaris. Removing the "patch" flag until a new one get's attached - I can not accept the attached, because they will cause regressions on Solaris. One option could be to use type -p or perl. The way OO.o opens a web browser or e-mail client has aged and needs some rethinking. Unfortunately this won't be ready for OOo 3.0, so shifting this issue to 3.x. maintainer changed. Reset assignee on issues not touched by assignee in more than 1000 days. |