Issue 31837

Summary:

status bar config crasher ...

Product:

General

Reporter:

mmeeks <mmeeks>

Component:

code

Assignee:

carsten.driesner

Status:

CLOSED FIXED

QA Contact:

issues@framework <issues>

Severity:

Trivial

Priority:

P1 (highest)

CC:

issues, joerg.barfurth, Mathias_Bauer, stx123

Version:

OOo 1.1.2

Target Milestone:

OOo 1.1.3

Hardware:

All

OS:

All

Issue Type:

PATCH

Latest Confirmation in:

---

Developer Difficulty:

---

Attachments:

Description	Flags
the patch	none

Description mmeeks 2004-07-21 12:45:36 UTC

Rather an obvious cache pollution issue in the code.
To reproduce the crasher; start oowriter, click on the status bar, go to
re-configure the status bar in Tools->Configure->Status Bar, change some of the
options; then close, double click on the status bar - bang.

Attached patch fixes the problem; thanks to Ashwanth for some debugging insight.

Comment 1 mmeeks 2004-07-21 12:46:12 UTC

Created attachment 16653 [details]
the patch

Comment 2 mmeeks 2004-07-21 12:47:07 UTC

Incidentally - I'd like to see this in 1.1.3 as well - if it's possible.

Comment 3 carsten.driesner 2004-07-21 13:15:32 UTC

CD: We have some strong doubts that the patch from Ashwanth fixes the problem
correctly. He removed a call to a virtual method of a statusbar controller and
instead calls the statusbar method. 
I also cannot see that this is a P1 which prevents anybody from working!

Comment 4 carsten.driesner 2004-07-21 15:06:32 UTC

CD->mmeeks: Can you please join the discussion on the mailing list
dev@framework.openoffice.org where we clearly stated our doubts that the fix is
correct.
I think it is not a good style to force the integration of a bug fix when two
developers have strong doubts and think that it breaks other code parts. I will
accept a P2 task to fix this issue or a patch that fixes the root cause without
breaking something.

Comment 5 mmeeks 2004-07-21 16:12:04 UTC

please read the patch, it is not Ashwanth's; but a re-write.
Perhaps you'd like to explain how the cache pointer gets cleaned up otherwise :-)

Comment 6 carsten.driesner 2004-07-22 07:30:43 UTC

CD->mmeeks: Sorry, I misunderstand your description. Your patchs looks good to
me and will integrate it into my current CWS for OOo 2.0. I have to clarify
which CWS I can use to integrate your patch into OOo 1.1.3. Thanks for your
patch and help.

Comment 7 carsten.driesner 2004-07-22 07:31:23 UTC

CD: Patch accepted.

Comment 8 andreas.schluens 2004-07-26 12:35:29 UTC

Reviewed and approved.

Comment 9 mmeeks 2004-07-26 16:43:59 UTC

So what CWS's should this go to ? and can you commit it to save me the pain ? :-)

Comment 10 carsten.driesner 2004-07-26 16:49:45 UTC

CD->mmeeks: CWS ooo113fix2, I already commit the changes.

Comment 11 carsten.driesner 2004-09-15 09:11:58 UTC

CD: Verified fix in SRX645m46. No crash anymore => verified.

Comment 12 andreschnabel 2004-10-02 18:40:31 UTC

closing issue as there is no crash in 1.1.3rc