Issue 120017

Summary: [From Symphony]Filter is not shown in merged cell
Product: Calc Reporter: Yan Ji <yanji.yj>
Component: editingAssignee: zhang jianfang <zhangjf>
Status: CLOSED FIXED QA Contact:
Severity: Normal    
Priority: P3 CC: aoo.zhaoshzh, liushenf, shanzhu33, zhangjf
Version: 3.4.0   
Target Milestone: 4.0.0   
Hardware: PC   
OS: All   
Issue Type: DEFECT Latest Confirmation in: ---
Developer Difficulty: ---
Attachments:
Description Flags
sample
none
show filter button in merged cell
aoo.zhaoshzh: review?
show filter button in merged cell
zhangjf: review+
sample file none

Description Yan Ji 2012-06-18 02:25:45 UTC 
Build: AOO3.4

Open attached sample file

Defect: The filter is not shown in cell A1 and D1 which is merged cell
Comment 1 Yan Ji 2012-06-18 02:28:24 UTC 
Created attachment 78365 [details]
sample
Comment 2 zhaoshzh 2012-06-18 07:34:07 UTC 
I am investigating this issue.
1. the root cause
OO does not show filter button when there is a merged cell.
and when user click on the cell,not show the popup window.

2. If a filter button is in the range of merged cell,show it when
the merge is in vertical, and show it in the last cell when
the merge is in horizental.

When a user click on the fitler,show it in the merged cell.

here is the patch.
Comment 3 zhaoshzh 2012-06-18 07:58:19 UTC 
Created attachment 78376 [details]
show filter button in merged cell

show filter button in merged cell
Comment 4 zhaoshzh 2012-06-18 07:58:20 UTC 
Created attachment 78377 [details]
show filter button in merged cell

show filter button in merged cell
Comment 5 zhang jianfang 2012-06-21 03:02:20 UTC 
Comment on attachment 78377 [details]
show filter button in merged cell

I will review it.
Comment 6 zhang jianfang 2012-06-21 08:24:49 UTC 
The patch is very good. Committed it to trunk by revision r1352444.
Comment 7 zhang jianfang 2012-06-21 08:25:39 UTC 
Comment on attachment 78377 [details]
show filter button in merged cell

Set review pass flag.
Comment 8 Shan Zhu 2012-08-20 06:54:39 UTC 
Verified on r1374181. It works.
Comment 9 Shenfeng Liu 2012-10-09 07:33:45 UTC 
set Target Milestone to AOO 3.5.0 for PM purpose.
Comment 10 Shenfeng Liu 2012-12-18 06:24:54 UTC 
Created attachment 80039 [details]
sample file

add another sample file.